Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upload input values and logic #1598

Merged
merged 20 commits into from
Mar 23, 2023
Merged

Update upload input values and logic #1598

merged 20 commits into from
Mar 23, 2023

Commits on Mar 23, 2023

  1. Update upload input description in analyze

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    9894ad1 View commit details
    Browse the repository at this point in the history

  2. Update failed runs' upload SARIF logic 

    Previously, failed runs' failed SARIF files were uploaded if the `upload` input was not `true`. Now, the failed SARIF files will be uploaded if the `upload` input was not `always`, `failure-only`, or `true`.
    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4052ce5 View commit details
    Browse the repository at this point in the history

  3. Update green runs' upload SARIF logic 

    Previously, we uploaded results from the `analyze` step if the `upload` input was `true`. We now upload results if the `upload` input was set to `true` or `always`.
    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a99d06f View commit details
    Browse the repository at this point in the history

  4. Add test cases for failure-only, never, and unrecognized input

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    452dc6e View commit details
    Browse the repository at this point in the history

  5. Minor refactoring

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    cb6d164 View commit details
    Browse the repository at this point in the history

  6. Replace false with never in existing checks

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    8075d10 View commit details
    Browse the repository at this point in the history

  7. Fall back to always for unrecognized input

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    7676afe View commit details
    Browse the repository at this point in the history

  8. Add CHANGELOG entry

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    fb18766 View commit details
    Browse the repository at this point in the history

  9. Add unit tests for always, true, false cases

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    04e3995 View commit details
    Browse the repository at this point in the history

  10. Clarify CHANGELOG and Action input description 

    Co-authored-by: Henry Mercer <[email protected]>
    @angelapwen @henrymercer
    angelapwen and henrymercer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    3270250 View commit details
    Browse the repository at this point in the history

  11. Specify upload skips rather than fails in test

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    7e7bc84 View commit details
    Browse the repository at this point in the history

  12. Refactor relevant into helper method

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    cde6edb View commit details
    Browse the repository at this point in the history

  13. Further documentation improvements 

    Co-authored-by: Henry Mercer <[email protected]>
    @angelapwen @henrymercer
    angelapwen and henrymercer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    2a441e3 View commit details
    Browse the repository at this point in the history

  14. Update input description to match existing ones

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    690a1ab View commit details
    Browse the repository at this point in the history

  15. Refactor utility function per PR review

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    13a94c3 View commit details
    Browse the repository at this point in the history

  16. Refactor test cases into loop

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4469ee6 View commit details
    Browse the repository at this point in the history

  17. Make getUploadValue synchronous

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    707a6bb View commit details
    Browse the repository at this point in the history

  18. Update comment 

    Co-authored-by: Henry Mercer <[email protected]>
    @angelapwen @henrymercer
    angelapwen and henrymercer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    7929472 View commit details
    Browse the repository at this point in the history

  19. Use switch statement

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    54e08db View commit details
    Browse the repository at this point in the history

  20. Stop awaiting non async function

    @angelapwen
    angelapwen committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    532e9ec View commit details
    Browse the repository at this point in the history