Telemetry: Nest alertCounts object in event_report.properties
#1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
approved these changes
Jul 11, 2023
|
I'll hold off on merging until the current QA run is confirmed to have completed! |
angelapwen
added
DO NOT MERGE
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for QA runs, we were sending the map of alerts to counts as a top-level object in the event report
propertiesbag. Because we eventually would like to send other (different) properties attached to events, let's nest them under analertCountsobject inproperties.This change will take effect before the next QA run, for v2.14.1.
[Internal only]: Test run with the new format. I have also confirmed by querying the data warehouse, which I will link in backlinked issue.
Merge / deployment checklist