Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only print the analysis summary once #1811

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Only print the analysis summary once #1811

merged 2 commits into from
Jul 28, 2023

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Jul 28, 2023 •
edited
Loading

Currently we print the analysis summary twice, once within the "interpreting results" log group, and once at the top-level of the analyze Action logs. This PR changes this so we print the analysis summary once at the top-level.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer force-pushed the henrymercer/print-summary-once branch from f714be1 to 89dc667 Compare July 28, 2023 11:13
@henrymercer henrymercer force-pushed the henrymercer/print-summary-once branch from 89dc667 to 8342844 Compare July 28, 2023 11:29
@henrymercer henrymercer marked this pull request as ready for review July 28, 2023 12:06
@henrymercer henrymercer requested a review from a team as a code owner July 28, 2023 12:06
angelapwen
angelapwen approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, interesting workaround 👍

@henrymercer henrymercer merged commit 10c6bfe into main Jul 28, 2023
@henrymercer henrymercer deleted the henrymercer/print-summary-once branch July 28, 2023 13:24
@github-actions github-actions bot mentioned this pull request Jul 28, 2023
Merged
6 tasks
@henrymercer henrymercer mentioned this pull request Aug 10, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @angelapwen