Add support for aliasing languages like C/C++, Java/Kotlin, and JS/TS #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelapwen
previously approved these changes
Sep 14, 2023
| /** | ||
| * Versions 2.14.4+ of the CodeQL CLI support language aliasing. | ||
| */ | ||
| export const CODEQL_VERSION_LANGUAGE_ALIASING = "2.14.4"; |
There was a problem hiding this comment.
Hm.. should we bump this to 2.14.5 given its rollout on dotcom was stopped and bumped directly to 2.14.5?
There was a problem hiding this comment.
2.14.5 is identical to 2.14.4 apart from a JavaScript fix, so I think it's fine to use 2.14.4 here. As you say though, it doesn't affect that many customers.
| @@ -5,6 +5,7 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th | |||
| ## [UNRELEASED] | |||
|
|
|||
| - Update default CodeQL bundle version to 2.14.5. [#1882](https://github.com/github/codeql-action/pull/1882) | |||
| - Enable the following language aliases when using CodeQL 2.14.4 and later: `c-cpp` for C/C++ analysis, `java-kotlin` for Java/Kotlin analysis, and `javascript-typescript` for JavaScript/TypeScript analysis. [#1883](https://github.com/github/codeql-action/pull/1883) | |||
There was a problem hiding this comment.
Same comment as above on whether we want to move this to 2.14.5.
Z80coder
approved these changes
Sep 15, 2023
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
c-cpp,java-kotlin, andjavascript-typescriptaliases for C/C++, Java/Kotlin, and JavaScript/TypeScript analysis. To ensure a consistent experience across all CodeQL products, we implemented these aliases in the CLI, so this PR is really just exposing that functionality.Merge / deployment checklist