Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect Linux cgroup CPU number for --threads value #2083

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Respect Linux cgroup CPU number for --threads value #2083

merged 6 commits into from
Jan 23, 2024

Commits on Jan 22, 2024

  1. Respect Linux cgroup CPU number for --threads value 

    We want to respect `cgroup` constraints so that when we run in a container, the default max threads value is appropriately set to the maximum number of cores in this container rather than the host OS's.

We check both `/sys/fs/cgroup/cpuset.cpus.effective` (`cgroup v2`) and `/sys/fs/cgroup/cpuset.cpus` (`cgroup v1`) to find the number of cores.
    @angelapwen
    angelapwen committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b0e35ba View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream' into use-cgroup-for-threads

    @angelapwen
    angelapwen committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    354aec0 View commit details
    Browse the repository at this point in the history

  3. Add changenote

    @angelapwen
    angelapwen committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    dd78af3 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Also respect limit from cgroup/cpu.max

    @angelapwen
    angelapwen committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ef58de3 View commit details
    Browse the repository at this point in the history

  2. Address PR review comments

    @angelapwen
    angelapwen committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8e735f0 View commit details
    Browse the repository at this point in the history

  3. Allow for multi-digit core indices

    @angelapwen
    angelapwen committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4acf5be View commit details
    Browse the repository at this point in the history