Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a README section about supported versions #2100

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

henrymercer
Copy link
Contributor

This information is already included in the changelog, but let's surface it in the README to so that it's more visible.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner January 26, 2024 14:10
@jsoref
Copy link
Contributor

jsoref commented Jan 26, 2024

Thanks. This text is very helpful.

It's probably worth mentioning that workflows running outside GHES on v2 will trigger node16 depreciation warnings on each and every run.

It's a bit surprising. (I have a customer that filed a ticket asking me to release an upgrade so that the warning goes away. - thankfully I had already been working on fixing it because I also find the warning very annoying, but it took me quite a bit to develop and validate a fix for one of the other breaking action updates.)

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up.

@henrymercer
Copy link
Contributor Author

I think I'll merge this as is, since we produce our own warning as well about upgrading from v2 to v3 (when the user's running on a GitHub instance that supports Node 20 Actions).

@henrymercer henrymercer merged commit 25f779c into main Jan 26, 2024
317 checks passed
@henrymercer henrymercer deleted the henrymercer/readme-note-on-supported-versions branch January 26, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants