Treat status reports as non-critical #2121
Merged
+146
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelapwen
reviewed
Feb 8, 2024
jsoref
force-pushed
the
status-reports-are-not-critical
branch
2 times, most recently
from
6145d06
to
d3f9862
Compare
aeisenberg
reviewed
Feb 9, 2024
jsoref
force-pushed
the
status-reports-are-not-critical
branch
from
ac030dd
to
5942183
Compare
aeisenberg
previously approved these changes
Feb 9, 2024
| @@ -16,6 +16,11 @@ import { parseRepositoryNwo, RepositoryNwo } from "./repository"; | |||
| import * as util from "./util"; | |||
| import { SarifFile, ConfigurationError, wrapError } from "./util"; | |||
|
|
|||
| const GENERIC_403_MSG = | |||
| "The repo on which this action is running has not opted-in to CodeQL code scanning."; | |||
There was a problem hiding this comment.
This message and the one below it needs some work, but as you mentioned, it is outside the scope of this PR.
|
Thanks again for your work on this. |
jsoref
commented
Feb 12, 2024
aeisenberg
previously approved these changes
Feb 12, 2024
Change `sendStatusReport` to `void`
jsoref
force-pushed
the
status-reports-are-not-critical
branch
from
df25046
to
5a6da1d
Compare
aeisenberg
approved these changes
Feb 12, 2024
|
Thanks again! Nice work here. |
8 tasks
13 tasks
This was referenced May 13, 2024
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve github/codeql#15462 (comment) by converting
sendStatusReportinto a function that always returnsvoidand usescore.warninginstead ofcore.errorSplit from:
Merge / deployment checklist