Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running debug artifacts checks on MacOS #2123

Merged

Conversation

angelapwen
Copy link
Contributor

These checks take a while, and there's no specific reason to run them on MacOS in particular. We run them only on ubuntu-latest instead.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen marked this pull request as ready for review February 8, 2024 17:13
@angelapwen angelapwen requested a review from a team as a code owner February 8, 2024 17:13
@angelapwen angelapwen enabled auto-merge (squash) February 8, 2024 17:37
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, but this looks good.

fi
done
popd
pushd "./my-debug-artifacts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer need pushd/popd since there's only one directory now.

Suggested change
pushd "./my-debug-artifacts"
cd "./my-debug-artifacts"

done
popd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
popd

@angelapwen angelapwen merged commit 3ab1d29 into github:main Feb 9, 2024
589 checks passed
@angelapwen
Copy link
Contributor Author

Sorry, I'd set this to auto-merge and it merged as soon as you approved 😆

@angelapwen angelapwen deleted the remove-macos-debug-artifacts-check branch February 13, 2024 12:18
angelapwen added a commit to angelapwen/codeql-action that referenced this pull request Feb 13, 2024
Suggested in github#2123 but was automerged before I could apply the suggestion
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants