-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop running debug artifacts checks on MacOS #2123
Stop running debug artifacts checks on MacOS #2123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion, but this looks good.
fi | ||
done | ||
popd | ||
pushd "./my-debug-artifacts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer need pushd/popd since there's only one directory now.
pushd "./my-debug-artifacts" | |
cd "./my-debug-artifacts" |
done | ||
popd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
popd |
Sorry, I'd set this to auto-merge and it merged as soon as you approved 😆 |
Suggested in github#2123 but was automerged before I could apply the suggestion
These checks take a while, and there's no specific reason to run them on MacOS in particular. We run them only on
ubuntu-latest
instead.Merge / deployment checklist