Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when using build modes and autobuild fails #2206

Merged

Conversation

henrymercer
Copy link
Contributor

Include a more specific error message tailored to the CodeQL Action.

Also wrap configuration errors in all CLI invocations, since the patterns we've specified in cli-errors.ts are specific enough that to be applied to all CLI invocations without creating false negative failures.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner March 20, 2024 20:36
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good re. wrapping all CLI invocations 👍

@henrymercer henrymercer merged commit 9c0c35b into main Mar 20, 2024
297 checks passed
@henrymercer henrymercer deleted the henrymercer/improved-autobuild-error-with-build-modes branch March 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants