Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for on-demand feature flags #2280

Merged
merged 5 commits into from
May 10, 2024
Merged

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented May 9, 2024

This PR adds support for adding a new feature flag to the CodeQL Action without needing to make a corresponding change to an internal codebase.

Specifically, new features can be specified in a features query parameter delivered to the feature flags API.

While we're here, we also log feature flags on separate lines to avoid feature enablement being truncated.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner May 9, 2024 12:54
angelapwen
angelapwen previously approved these changes May 9, 2024
src/feature-flags.ts Outdated Show resolved Hide resolved
src/feature-flags.ts Show resolved Hide resolved
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@henrymercer henrymercer merged commit 4a51972 into main May 10, 2024
320 checks passed
@henrymercer henrymercer deleted the henrymercer/on-demand-ffs branch May 10, 2024 16:37
@github-actions github-actions bot mentioned this pull request May 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants