Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog entry section #2372

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix changelog entry section #2372

merged 1 commit into from
Jul 12, 2024

Conversation

henrymercer
Copy link
Contributor

I just noticed that the changelog entry for #2368 is in the wrong section — this PR fixes that. It's a common mistake with automatic merge resolution in that file — we should consider dropping unreleased changelog entries in a folder instead like we do for the CLI.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner July 12, 2024 17:21
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks. I should have caught that.

@henrymercer henrymercer merged commit c2585ec into main Jul 12, 2024
310 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-changelog branch July 12, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants