Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to eslint.config.mjs #2374

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Migrate to eslint.config.mjs #2374

merged 3 commits into from
Jul 17, 2024

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jul 16, 2024 •
edited
Loading

.eslintrc.json is deprecated.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg
Migrate to eslint.config.mjs
3cf7236 
`.eslintrc.json` is deprecated.
@aeisenberg aeisenberg requested a review from a team as a code owner July 16, 2024 17:12
@aeisenberg aeisenberg added the Update dependencies Trigger PR workflow to update dependencies label Jul 16, 2024
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pushed a commit to update the checked-in dependencies. Please mark the PR as ready for review to trigger PR checks.

@github-actions github-actions bot marked this pull request as draft July 16, 2024 22:21
@aeisenberg aeisenberg marked this pull request as ready for review July 16, 2024 22:29
angelapwen
angelapwen approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 👍

NlightNFotis
NlightNFotis approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeisenberg aeisenberg merged commit 8e14792 into main Jul 17, 2024
310 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/eslint branch July 17, 2024 15:36
This was referenced Jul 18, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

@NlightNFotis NlightNFotis NlightNFotis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aeisenberg @NlightNFotis @angelapwen