Add swift+linux deprecation #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharad
reviewed
Aug 1, 2024
CHANGELOG.md
Outdated
| @@ -6,15 +6,15 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the | |||
|
|
|||
| ## [UNRELEASED] | |||
|
|
|||
| No user facing changes. | |||
| - _Deprecation:_ Analyzing databases on Swift support on Ubuntu runner images is no longer supported. Please migrate to a MacOS runner if this affects you. | |||
There was a problem hiding this comment.
Can we get the Action to produce a deprecation warning if it detects the combination of Swift and Linux?
There was a problem hiding this comment.
Yes. @angelapwen will work on that.
There was a problem hiding this comment.
I've added the warning in #2399.
Co-authored-by: Aditya Sharad <[email protected]>
adityasharad
previously approved these changes
Aug 1, 2024
angelapwen
reviewed
Aug 2, 2024
3 tasks
angelapwen
approved these changes
Aug 2, 2024
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist