Bump the npm group across 1 directory with 2 updates #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the npm group with 2 updates in the / directory: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 7.17.0 to 8.0.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.0.1/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 7.17.0 to 8.0.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.0.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
Update dependencies
github-actions
bot
removed
the
Update dependencies
|
Pushed a commit to update the checked-in dependencies. Please mark the PR as ready for review to trigger PR checks. |
|
cc @NlightNFotis since you're on 🛡️ duty this week. Would you mind reviewing my changes? |
NlightNFotis
approved these changes
Aug 6, 2024
| @@ -43,7 +43,7 @@ const core = __importStar(require("@actions/core")); | |||
| const toolrunner = __importStar(require("@actions/exec/lib/toolrunner")); | |||
| const safeWhich = __importStar(require("@chrisgavin/safe-which")); | |||
| const util_1 = require("./util"); | |||
| // eslint-disable-next-line import/no-commonjs | |||
| // eslint-disable-next-line import/no-commonjs, @typescript-eslint/no-require-imports | |||
There was a problem hiding this comment.
Why are we getting the typescript-eslint alert if we already have the eslint import/no-commonjs one? Is it a matter of it being copied in the js file by the TypeScript compiler?
There was a problem hiding this comment.
I think there's some duplication within our set of enabled ESLint rules that is causing this problem to be picked up by two rules. We should take a look at the set of enabled rules as a low priority followup.
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the npm group with 2 updates in the / directory: @typescript-eslint/eslint-plugin and @typescript-eslint/parser.
Updates
@typescript-eslint/eslint-pluginfrom 7.17.0 to 8.0.1Release notes
Sourced from
@typescript-eslint/eslint-plugin's releases.... (truncated)
Changelog
Sourced from
@typescript-eslint/eslint-plugin's changelog.... (truncated)
Commits
e05c2e5chore(release): publish 8.0.1fbcfabachore: enable unicorn/no-useless-spread (#9687)6a9674dfix(eslint-plugin): [no-unused-vars] ignore imports used only as types (#9694)1db993achore(release): publish 8.0.0ce09260docs(eslint-plugin): [no-unnecessary-type-parameters] add admonition about ru...b8274d3fix(rule-tester): provide Linter a cwd in its constructor (#9678)1b0468eMerge branch 'main'838dd0cchore: use parserOptions.projectService internally (#9659)35cf3d2chore(release): publish 7.18.046a5709docs: link no-duplicate-type-constituents and no-redundant-type-constituents ...Updates
@typescript-eslint/parserfrom 7.17.0 to 8.0.1Release notes
Sourced from
@typescript-eslint/parser's releases.... (truncated)
Changelog
Sourced from
@typescript-eslint/parser's changelog.Commits
e05c2e5chore(release): publish 8.0.11db993achore(release): publish 8.0.01b0468eMerge branch 'main'35cf3d2chore(release): publish 7.18.0f3dfc0aMerge branch 'main' into v8ae980e3Merge branch 'main'c365664Merge branch 'main'6bd4211Merge branch 'main'a846ffeMerge branch 'main'9311c69Merge branch 'main'Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions