Only run check SIP enablement once in init step
#2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
henrymercer
previously approved these changes
Aug 23, 2024
src/util.ts
Outdated
| logger: Logger, | ||
| ): Promise<boolean | undefined> { | ||
| if (process.env[EnvVar.IS_SIP_ENABLED] !== undefined) { |
There was a problem hiding this comment.
We may also want to check that it's not the empty string (or defensively that it's either "true" or "false")
There was a problem hiding this comment.
I can check if it's "true" or "false" 👍 good suggestion!
henrymercer
previously approved these changes
Aug 23, 2024
Co-authored-by: Henry Mercer <[email protected]>
|
Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks. |
henrymercer
approved these changes
Aug 23, 2024
8 tasks
angelapwen
added a commit
that referenced
this pull request
Aug 23, 2024
* Update changelog and version after v3.26.4 * Update checked-in dependencies * Only run check SIP enablement once in `init` step (#2441) Co-authored-by: Henry Mercer <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update changelog for v3.26.5 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Angela P Wen <[email protected]> Co-authored-by: Henry Mercer <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2434 we stopped calling the
dfsystem binary on MacOS ARM runners where SIP was disabled, but the actual call tocsrutilitself was run again and is also a binary 😸This change makes it so that
csrutilis only called once, in theinitstep before the build tracer environment variables are set, and then its result is saved in an environment variable.Merge / deployment checklist