-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "recommended" to "minimum" #2451
Conversation
For posterity, following the recommendation and pinning the recommended version (e.g., |
Maybe we should explicitly state something like: we recommend pinning to the major version tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea here. Couple of points:
- How do we clarify that Enterprise Server 3.10 does not support CodeQL Action v3, because it does not support running Actions using Node 20? And Enterprise Server 3.11 only supports CodeQL Action v3 if you pull in v3 using GitHub Connect?
- Does the Dotcom entry still make sense? It might be worth removing it.
I'll add a new column "Notes" to add this info.
No. Now that it is explicitly "minimum" version, I agree that this should be removed. |
The wording was causing confusion.
ec418c1
to
c283379
Compare
The wording was causing confusion.
Merge / deployment checklist