Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Checks: update artifacts tests #2535

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented Oct 8, 2024

We are planning to make the default behavior of the CODEQL_ACTION_ARTIFACT_V4_UPGRADE feature flag to be true. This change updates our debug artifact PR checks so that the relevant environment variable is set to true, and changes the debug-artifacts-upgrade test to debug-artifacts-legacy test.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

We are planning to make the default behavior of the `CODEQL_ACTION_ARTIFACT_V4_UPGRADE` feature flag to be true. This change updates our debug artifact PR checks so that the relevant environment variable is set to `true`, and changes the `debug-artifacts-upgrade` test to `debug-artifacts-legacy` test.
@angelapwen angelapwen marked this pull request as ready for review October 8, 2024 21:05
@angelapwen angelapwen requested a review from a team as a code owner October 8, 2024 21:05
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@angelapwen angelapwen merged commit 9d1e406 into main Oct 8, 2024
546 checks passed
@angelapwen angelapwen deleted the angelapwen/update-artifacts-tests branch October 8, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants