Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use Zstandard bundles on Windows #2537

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Don't use Zstandard bundles on Windows #2537

merged 2 commits into from
Oct 10, 2024

Conversation

henrymercer
Copy link
Contributor

In testing, gzip performs better than Zstandard on Windows.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer
Don't use Zstandard bundles on Windows
eefb943 
In testing, gzip performs better than Zstandard on Windows.
@henrymercer henrymercer requested a review from a team as a code owner October 10, 2024 18:24
aeisenberg
aeisenberg reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wild...I didn't expect that.

pr-checks/checks/zstd-bundle.yml Show resolved Hide resolved
aeisenberg
aeisenberg approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@henrymercer henrymercer merged commit 38469af into main Oct 10, 2024
276 checks passed
@henrymercer henrymercer deleted the henrymercer/no-zstd-windows branch October 10, 2024 18:53
This was referenced Oct 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @aeisenberg