fix: persist inputs between the upload action and its post step

[NlightNFotis]

Description

This PR is fixing an issue with persisting action inputs between steps of the runner. This is an issue that is downstream of a problem with the GitHub Actions runner, ref: actions/runner#3514

Closes #2553

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Confirm the readme has been updated if necessary. (Bug fix, doesn't need a change in readme).
• Confirm the changelog has been updated if necessary. (Ported changelog entry from Work around broken github/runner input handling for post steps #2554, an alternative fix for the original issue)

Acknowledgments

• Thanks to @chrisgavin for the code that formed the basis of this PR, and @jsoref for the original issue report, a PR containing code leading us to a solution, and for helping us iterate on this PR by testing our changes and proposing further improvements.

[jsoref]

Looks good to me. Tested it https://github.com/check-spelling-sandbox/check-spelling/actions/runs/11439466596/job/31823193138 and it worked. (The patch partially failed to apply because the source map wasn't a match to the version included in the runner cache, but that isn't a requirement -- and when I was doing my testing, I didn't include the source map file.)

Note that there are four actions that use post:. If I were maintaining this repository, I'd patch all of them otherwise, there's a risk that someone else gets tripped up that this only works in some code paths...

[jsoref]

@NlightNFotis can you cherry-pick d9886b8 ? VSCode automatically wanted to remove that whitespace...

[NlightNFotis]

@NlightNFotis can you cherry-pick d9886b8 ? VSCode automatically wanted to remove that whitespace...

Hm, I want to do that, but I get

❯ git cherry-pick d9886b85848afc58f19094c760535a6dd1a8cf77
fatal: bad object d9886b85848afc58f19094c760535a6dd1a8cf77

I think the original branch with this change has been deleted, so it cannot find the commit. I also looked into your fork and I cannot find the branch there.

Would it be possible to extract it as a patch and post it here as a comment? @jsoref

[jsoref]

You can grab it from https://github.com/github/codeql-action/commit/d9886b85848afc58f19094c760535a6dd1a8cf77.patch

[NlightNFotis]

@jsoref Done! Thanks again for your time and effort helping us get to a good state in our code! Your input is greatly appreciated.

[henrymercer]

I am not sure whether this is happening due to a bug or an intended omission in the mechanisms for passing inputs, but the fix LGTM.

[NlightNFotis]

@henrymercer Thank you for the review, I have integrated all of the changes in 9bc4ee1. Would you please have another look at this one?

[henrymercer]

Thanks @jsoref, @chrisgavin, and @NlightNFotis!