Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency caching: small output improvements #2597

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

mbg
Copy link
Member

@mbg mbg commented Nov 12, 2024

This PR makes two small changes related to dependency caching to improve the Action's output during normal operation:

  • We intercept ReserveCacheError errors when saving caches, since these are expected when a cache already exists for a given cache key. We log a message indicating this instead of propagating the error itself.
  • We allow warnings from tryGetFolderBytes to be suppressed, which would otherwise result in check annotations for a workflow run. This occurs during normal operation, since we try to calculate the cache size for all folders that may need to be cached for a given language, whether they exist or not. If they do not exist, that's not a problem for us.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@mbg mbg self-assigned this Nov 12, 2024
@mbg mbg requested a review from a team as a code owner November 12, 2024 15:20
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@mbg mbg merged commit 3ab67a2 into main Nov 14, 2024
271 checks passed
@mbg mbg deleted the mbg/caching/output-improvements branch November 14, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants