workaround: disable streaming when downloading codeql bundle #2599
Conversation
src/tools-download.ts
Outdated
| if (compressionMethod === "zstd" && process.platform === "linux") { | ||
| // TODO: Re-enable streaming when we have a more reliable way to respect proxy settings. | ||
| // eslint-disable-next-line no-constant-condition, no-constant-binary-expression | ||
| if (false && compressionMethod === "zstd" && process.platform === "linux") { |
There was a problem hiding this comment.
Can you turn false into an environment variable? This way at least we can selectively enable it.
Maybe something like:
| if (false && compressionMethod === "zstd" && process.platform === "linux") { | |
| if (process.env[EnvVar.STREAM_BUNDLE_DOWNLOAD] !== "true" && compressionMethod === "zstd" && process.platform === "linux") { |
And then add the variable to the EnvVar class?
|
@aeisenberg @henrymercer , thank you both for your reviews. I've implemented Henry's request which I found to be in the intersection of what both of you suggested. Would it be possible to have another look at this? |
src/codeql.test.ts
Outdated
| @@ -39,6 +41,15 @@ setupTests(test); | |||
|
|
|||
| let stubConfig: Config; | |||
|
|
|||
| // TODO: Remove when when we no longer need to pass in features | |||
There was a problem hiding this comment.
Can you link to the issue for this? I think it's this one: #2600
src/setup-codeql.test.ts
Outdated
| @@ -25,6 +27,14 @@ import { | |||
|
|
|||
| setupTests(test); | |||
|
|
|||
| // TODO: Remove when when we no longer need to pass in features | |||
There was a problem hiding this comment.
Same...can you link to #2600?
| @@ -25,6 +27,14 @@ import { | |||
|
|
|||
| setupTests(test); | |||
|
|
|||
| // TODO: Remove when when we no longer need to pass in features | |||
| const expectedFeatureEnablement: FeatureEnablement = initializeFeatures( | |||
There was a problem hiding this comment.
Nit: update initializeFeatures to return FeatureEnablement so we can remove this cast.
NlightNFotis
dismissed stale reviews from henrymercer and aeisenberg
via
427ce46
|
@henrymercer @aeisenberg sorry for this, can you please re-approve, because I've added the link that Andrew asked for and it automatically dismissed the reviews. |
Description
This PR disables streaming the extraction of the CodeQL bundle as a temporary workaround to the issue described in #2593.
A proper fix will be implemented later so that we can stream while respecting proxy settings.
Fixes #2593
Merge / deployment checklist