-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into v1 #338
Merged
Merged
Merge main into v1 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, most tests were using https://github.com and only the first was using https://github.example.com. As it happens, https://github.com works for all of them.
Introduce parameter object for API params that travel together
Fix deprecated method Buffer.new
Remove the line to disable the "github/no-then" rule.
Update code so "github/no-then" passes
Validate the codeql-action workspace for common errors
Add a check to ensure expected CodeQL release files exist.
So that we can remove support for the beta configuration of `on: push`-only we should communicate a date after which this will not work.
Add an explicit deprecation date
Backport v1 into main
Handle the case where branches may be strings, wildcards
Merge v1 into main to fix conflicts
The first four PRs were also included in #328, and the remaining 6 (+2 mergeback PRs) are from this week. |
robertbrignull
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although there are 6 new PRs, there's barely anything new. The only substantial new piece of work from this week is the fix for the bug from last week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 494945f into v1
Conductor for this PR is @robertbrignull
Contains the following pull requests:
codeql-bundle-20201127
. #325 - Update the default bundle tocodeql-bundle-20201127
. (@chrisgavin)