Install Python 3 tools before installing Python 2 tools. #339
Conversation
There was a problem hiding this comment.
Nice, thanks 👍
I was slightly worried what would happen if we try to analyze some project as Python 2, and this step failed because python2 command wasn't available. But I guess we will figure out quick enough when trying to invoke the extractor with python2 😄
As a side question, do you know if python2 is available by default in environment the codeql-action runs on when it's based off Ubuntu 20.04 instead of Ubuntu 16.04?
Haha, yep my thoughts too.
Yes, |
This change is designed to reduce the fallout of issues with Python 2 dependency installation, since Python 2 is both less popular than Python 3 and also end-of-life meaning there are more likely to be issues with it as tools like Pip drop support for it.
Firstly it moves all the Python 2 steps to the end. This ensures that if they fail the script will have already done the Python 3 dependency installation, which is the one we likely care most about. It also wraps the Python 2 dependency installation in a check that Python 2 is actually present to avoid spurious warnings when you're only using Python 3 which is going to become more and more common.
I note that [there is a PowerShell version of this script, which I have not updated. This is because the PowerShell version already totally ignores all exit codes, so is already fairly safe when it comes to the Python 2 steps failing (although ignoring all exit codes obviously has its own problems).
Merge / deployment checklist