Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding path of temporary files. #385

Merged
merged 4 commits into from
Feb 15, 2021
Merged

Conversation

chrisgavin
Copy link
Contributor

This makes it so you can override the temporary directory used by the Action by setting the CODEQL_ACTION_TEMP environment variable.

I went with an environment variable instead of an input, both because I think it's advantageous to be able to override this for all jobs on self-hosted runners and because it allows you to set it once for the entire workflow rather than for each step.

This option is a useful escape hatch for Windows hosted runners, which have a very fast, but also very small temporary disk. This is used by default, but if the project is too big to build on this disk it's potentially useful to be able to use the larger, slower disk instead.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary. (I've opted not to update the readme; I don't think we necessarily want to advertise this option yet, but I think it's useful to have it ready if someone eventually needs it.)

@chrisgavin chrisgavin marked this pull request as ready for review February 1, 2021 15:38
src/actions-util.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@chrisgavin
Copy link
Contributor Author

I believe the Rubocop CI check failure is caused by a bug in the latest release of Bundler (rubygems/rubygems#4380). We might want to pin to a specific version in future, but for now I think we can just wait for an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants