Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use externalRepoAuth when getting a remote config #443

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Use externalRepoAuth when getting a remote config #443

merged 1 commit into from
Apr 9, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Apr 9, 2021 •
edited by adityasharad
Loading

This allows users to specify a different token for retrieving the
codeql config from a different repository.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@aeisenberg
Use externalRepoAuth when getting a remote config
1fc9636 
This allows users to specify a different token for retrieving the
codeql config from a different repository.

Fixes github/advanced-security-field#185
adityasharad
adityasharad approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick fix.
I see we were already passing around aGitHubApiExternalRepoDetails to check out query repos configured in the workflow file, so that case is already correct.

@aeisenberg
Copy link
Contributor Author

I see we were already passing around aGitHubApiExternalRepoDetails to check out query repos configured in the workflow file, so that case is already correct.

That's right. It's handled.

@aeisenberg aeisenberg merged commit 534192f into main Apr 9, 2021
@aeisenberg aeisenberg deleted the aeisenberg/external-repo-token branch April 9, 2021 22:00
This was referenced Apr 12, 2021
Merged
Closed
@github-actions github-actions bot mentioned this pull request Apr 19, 2021
Merged
@snyk-bot snyk-bot mentioned this pull request Jun 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasharad adityasharad adityasharad approved these changes

@sampart sampart Awaiting requested review from sampart

@robertbrignull robertbrignull Awaiting requested review from robertbrignull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeisenberg @adityasharad