Add the github-linguist package #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/add-github-linguist
branch
from
c5d6cae
to
d2b4652
Compare
This commit only adds a single package and all of its transitive dependencies. The github-linguist package will be used for counting lines of code as a baseline for databases we are analyzing.
aeisenberg
force-pushed
the
aeisenberg/add-github-linguist
branch
from
d2b4652
to
c4a84a9
Compare
robertbrignull
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
LGTM
As you say, this is just adding the library. So I wouldn't worry about the size of the PR. That's just an unfortunate side effect of having the node modules in the repository.
I don't really know if the upgrading of the package lock file is a problem or not, but I'm going to assume it's not. I still have an old version of npm and I tried checking out your branch and I could still do npm things without errors.
Merged
This was referenced Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit only adds a single package and all of its transitive
dependencies. The github-linguist package will be used for counting
lines of code as a baseline for databases we are analyzing.
The actual work to calculate the lines of code will come in a future PR.
This PR is surprisingly large and I'm not sure if that is a genuine
problem or not. The package-lock.json file has been upgraded from
v1 to v2 and this introduced some changes, but even when I tried to
install the package using and older version of npm, there were still
a large number of changes.
Merge / deployment checklist