Clarify the missing baseline lines of code warning message #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
reviewed
May 5, 2021
aeisenberg
force-pushed
the
aeisenberg/warning-message
branch
2 times, most recently
from
18e4667
to
9228317
Compare
henrymercer
approved these changes
May 5, 2021
|
All good suggestions. |
aeisenberg
force-pushed
the
aeisenberg/warning-message
branch
from
9228317
to
faa2564
Compare
|
Do you want to keep this at the warning level (which makes it visible in the Actions summary page), or drop it down to info/debug so it's only present in the logs view? |
|
Hmmm...didn't realize that this would be raised to being visible in the summary page. This is a good point. I'll drop down its verbosity. |
|
A debug message won't appear at all unless the debug flag is set to true. I'd be leaning towards using an info message. |
aeisenberg
force-pushed
the
aeisenberg/warning-message
branch
from
faa2564
to
e04c62b
Compare
adityasharad
approved these changes
May 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See github/codeql#5838
Merge / deployment checklist