Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C# line counting and add test #586

Merged
merged 4 commits into from
Jun 24, 2021
Merged

Fix C# line counting and add test #586

merged 4 commits into from
Jun 24, 2021
+5,601 −32

Conversation

edoardopirovano
Copy link
Contributor

@edoardopirovano edoardopirovano commented Jun 23, 2021 •
edited
Loading

Closes #584

This PR will fix our line counting for C# once aeisenberg/linguist#1 which fixes the underlying issue has been merged and a new release of github-linguist has been made to npm.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • [n/a] Confirm the readme has been updated if necessary.
  • [n/a] Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano marked this pull request as ready for review June 23, 2021 23:41
@edoardopirovano edoardopirovano requested a review from a team as a code owner June 23, 2021 23:41
@aeisenberg aeisenberg merged commit ac402bf into github:main Jun 24, 2021
@github-actions github-actions bot mentioned this pull request Jun 28, 2021
Merged
5 tasks
@CharliesAngel1 CharliesAngel1 mentioned this pull request Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot determine the number of lines in C# repository
2 participants
@edoardopirovano @aeisenberg