-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 'source-root' input to the init Action #607
Commits on Jun 29, 2021
-
Add 'source-root' input to init action
This input is exposed in the CodeQL CLI as the flag --source-root, allowing users of the CLI to set --source-root different from --working-dir. However, in codeql-action, these two paths are conflated and it poses problems for users with complicated build environments, in which a source root may be a child of the working directory. Most users should not notice this, as the default value is ${{ github.workspace }}, as it is implied now (`path.resolve()`).
Configuration menu - View commit details
-
Copy full SHA for 42babdf - Browse repository at this point
Copy the full SHA 42babdfView commit details -
Make 'source-root' init input relative to github.workspace
In the previous commit, the default value of the input is ${{ github.workspace }} which means that most uses of this input would probably prefix their paths with ${{ github.workspace }}, especially since actions/checkout's 'path' input must be under ${{ github.workspace }}. Therefore, it doesn't make much sense for this to be an absolute file path. Instead, it's more intuitive to make this relative to the repository.
Configuration menu - View commit details
-
Copy full SHA for 337ae83 - Browse repository at this point
Copy the full SHA 337ae83View commit details -
Remove '${{ github.workspace }}' from action.yml
It causes the action to break (or rather that context being unavailable causes it to fail), despite it being in the description field.
Configuration menu - View commit details
-
Copy full SHA for a05a7f9 - Browse repository at this point
Copy the full SHA a05a7f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57f584a - Browse repository at this point
Copy the full SHA 57f584aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1cd524 - Browse repository at this point
Copy the full SHA e1cd524View commit details
Commits on Jun 30, 2021
-
Refer to $GITHUB_WORKSPACE specifically in source-root description
Previously, I had tried to refer to '${{ github.workspace }}', but that caused a problem in Actions. Trying to avoid the issue, I changed this to "the workspace," but this gives up quite a bit of specificity. Co-authored-by: Arthur Baars <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 66df091 - Browse repository at this point
Copy the full SHA 66df091View commit details -
Use path.resolve instead of path.join for sourceRoot
Thanks to @aibaars, `path.resolve()` should will nicely handle more use-cases, namely absolute paths better than `path.join()`. Co-authored-by: Arthur Baars <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 35e1b55 - Browse repository at this point
Copy the full SHA 35e1b55View commit details -
Configuration menu - View commit details
-
Copy full SHA for a607042 - Browse repository at this point
Copy the full SHA a607042View commit details
Commits on Jul 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c6728b6 - Browse repository at this point
Copy the full SHA c6728b6View commit details -
Clarify 'source-root' description to include default path
This addresses @adityasharad's suggestions in PR #607.
Configuration menu - View commit details
-
Copy full SHA for 45c0f11 - Browse repository at this point
Copy the full SHA 45c0f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for c78fb87 - Browse repository at this point
Copy the full SHA c78fb87View commit details -
Use different config file for testing 'source-root' input
This config file 'ought to have some queries good for testing!
Configuration menu - View commit details
-
Copy full SHA for 028f98f - Browse repository at this point
Copy the full SHA 028f98fView commit details -
Delete 'packaing' from source-root test job name
The test is not related to packaging. Co-authored-by: Aditya Sharad <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 67d6f79 - Browse repository at this point
Copy the full SHA 67d6f79View commit details -
Avoid moving repo files out of \$GITHUB_WORKSPACE in 'source-root' test
Moving the files into ../action was causing the job to fail because it couldn't find the test directory anymore. According to @adityasharad, these 'mv's should not be necessary. Removing these means changing the path to the actions. I'm also removing the 'config-file' input to keep the test minimal. I think this will mean that CodeQL will use the default query suite, so I hope that this doesn't change the results.
Configuration menu - View commit details
-
Copy full SHA for 1c69fae - Browse repository at this point
Copy the full SHA 1c69faeView commit details -
Merge branch 'source-root-input' of github.com:mario-campos/codeql-ac…
…tion into source-root-input
Configuration menu - View commit details
-
Copy full SHA for 2ca807c - Browse repository at this point
Copy the full SHA 2ca807cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12f1cff - Browse repository at this point
Copy the full SHA 12f1cffView commit details -
Remove build.sh step from 'source-root' test
As this test is using only JS, it's not necessary to compile or analyze the other languages.
Configuration menu - View commit details
-
Copy full SHA for 2c0da4b - Browse repository at this point
Copy the full SHA 2c0da4bView commit details
Commits on Jul 2, 2021
-
Test presence of database instead of results of analysis
This is for PR #607, 'source-root' input test case.
Configuration menu - View commit details
-
Copy full SHA for b9217ca - Browse repository at this point
Copy the full SHA b9217caView commit details -
Add analyze step to 'source-root' input test case
Co-authored-by: Aditya Sharad <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 06c6845 - Browse repository at this point
Copy the full SHA 06c6845View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4a91a8 - Browse repository at this point
Copy the full SHA a4a91a8View commit details
Commits on Jul 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9932052 - Browse repository at this point
Copy the full SHA 9932052View commit details