-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add names to all pr-checks #713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe JavaScript -> JS and CSharp -> C# for brevity. Other than that LGTM.
...and we have to update our branch protection rules 😆 |
9fe2f7c
to
88bc9ac
Compare
Good call. Done. |
That's not a PR, though, is it? |
Odd...does not seem to be showing the new names. |
88bc9ac
to
1785bbb
Compare
I think automerge won't work due to the checks changing name? |
Yes, we have to change the Required checks in the branch protection rules in this repo's Settings page, to match the new check names. |
e567e17
to
e22a6cd
Compare
Going to need this PR to be force-pushed. It is getting confused because it is expecting all check names to pass, when they no longer exist. |
Small change to aid with debugging failing jobs. I tried to put the most important part of the name of each job first.
Merge / deployment checklist