Add a permissions block for generated workflows #902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all workflows are able to write security events. Fixes a bug where CI jobs were failing during the upload status report request if theref
property of the report was not the same as the PR ref.I changed the approach in this PR. Instead of adding a permissions block, I am changing how the
TEST_MODE
environment variable works. Now, when this variable is set, no status reports will be uploaded to code scanning.The reasoning is that code scans from forks will never be allowed to have
security-events: write
permissions for resources other than the current PR. This is a conscious decision and meant to prevent third parties from maliciously uploading new code scans for refs they do not control.See #889
Merge / deployment checklist