-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #13876 from michaelnebel/csharp/aspnetdlls
C#: Include ASP.NET assemblies in the standalone extraction.
- Loading branch information
Showing
6 changed files
with
348 additions
and
93 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
166 changes: 166 additions & 0 deletions
166
csharp/extractor/Semmle.Extraction.CSharp.Standalone/FileContent.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| using Semmle.Util; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.IO; | ||
| using System.Linq; | ||
| using System.Text.RegularExpressions; | ||
|
|
||
| namespace Semmle.BuildAnalyser | ||
| { | ||
|
|
||
| // <summary> | ||
| // This class is used to read a set of files and decide different properties about the | ||
| // content (by reading the content of the files only once). | ||
| // The implementation is lazy, so the properties are only calculated when | ||
| // the first property is accessed. | ||
| // </summary> | ||
| internal partial class FileContent | ||
| { | ||
| private readonly ProgressMonitor progressMonitor; | ||
| private readonly IUnsafeFileReader unsafeFileReader; | ||
| private readonly Func<IEnumerable<string>> getFiles; | ||
| private readonly Func<HashSet<string>> getAlreadyDownloadedPackages; | ||
| private readonly HashSet<string> notYetDownloadedPackages = new HashSet<string>(); | ||
| private readonly Initializer initialize; | ||
|
|
||
| public HashSet<string> NotYetDownloadedPackages | ||
| { | ||
| get | ||
| { | ||
| initialize.Run(); | ||
| return notYetDownloadedPackages; | ||
| } | ||
| } | ||
|
|
||
| private bool useAspNetDlls = false; | ||
|
|
||
| /// <summary> | ||
| /// True if any file in the source directory indicates that ASP.NET is used. | ||
| /// The following heuristic is used to decide, if ASP.NET is used: | ||
| /// If any file in the source directory contains something like (this will most like be a .csproj file) | ||
| /// <Project Sdk="Microsoft.NET.Sdk.Web"> | ||
| /// <FrameworkReference Include="Microsoft.AspNetCore.App"/> | ||
| /// </summary> | ||
| public bool UseAspNetDlls | ||
| { | ||
| get | ||
| { | ||
| initialize.Run(); | ||
| return useAspNetDlls; | ||
| } | ||
| } | ||
|
|
||
| internal FileContent(Func<HashSet<string>> getAlreadyDownloadedPackages, | ||
| ProgressMonitor progressMonitor, | ||
| Func<IEnumerable<string>> getFiles, | ||
| IUnsafeFileReader unsafeFileReader) | ||
| { | ||
| this.getAlreadyDownloadedPackages = getAlreadyDownloadedPackages; | ||
| this.progressMonitor = progressMonitor; | ||
| this.getFiles = getFiles; | ||
| this.unsafeFileReader = unsafeFileReader; | ||
| this.initialize = new Initializer(DoInitialize); | ||
| } | ||
|
|
||
|
|
||
| public FileContent(TemporaryDirectory packageDirectory, ProgressMonitor progressMonitor, Func<IEnumerable<string>> getFiles) : this(() => Directory.GetDirectories(packageDirectory.DirInfo.FullName) | ||
| .Select(d => Path.GetFileName(d) | ||
| .ToLowerInvariant()) | ||
| .ToHashSet(), progressMonitor, getFiles, new UnsafeFileReader()) | ||
| { } | ||
|
|
||
| private static string GetGroup(ReadOnlySpan<char> input, ValueMatch valueMatch, string groupPrefix) | ||
| { | ||
| var match = input.Slice(valueMatch.Index, valueMatch.Length); | ||
| var includeIndex = match.IndexOf(groupPrefix, StringComparison.InvariantCultureIgnoreCase); | ||
| if (includeIndex == -1) | ||
| { | ||
| return string.Empty; | ||
| } | ||
|
|
||
| match = match.Slice(includeIndex + groupPrefix.Length + 1); | ||
|
|
||
| var quoteIndex1 = match.IndexOf("\""); | ||
| var quoteIndex2 = match.Slice(quoteIndex1 + 1).IndexOf("\""); | ||
|
|
||
| return match.Slice(quoteIndex1 + 1, quoteIndex2).ToString().ToLowerInvariant(); | ||
| } | ||
|
|
||
| private static bool IsGroupMatch(ReadOnlySpan<char> line, Regex regex, string groupPrefix, string value) | ||
| { | ||
| foreach (var valueMatch in regex.EnumerateMatches(line)) | ||
| { | ||
| // We can't get the group from the ValueMatch, so doing it manually: | ||
| if (GetGroup(line, valueMatch, groupPrefix) == value.ToLowerInvariant()) | ||
| { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| private void DoInitialize() | ||
| { | ||
| var alreadyDownloadedPackages = getAlreadyDownloadedPackages(); | ||
| foreach (var file in getFiles()) | ||
| { | ||
| try | ||
| { | ||
| foreach (ReadOnlySpan<char> line in unsafeFileReader.ReadLines(file)) | ||
| { | ||
|
|
||
| // Find the not yet downloaded packages. | ||
| foreach (var valueMatch in PackageReference().EnumerateMatches(line)) | ||
| { | ||
| // We can't get the group from the ValueMatch, so doing it manually: | ||
| var packageName = GetGroup(line, valueMatch, "Include"); | ||
| if (!string.IsNullOrEmpty(packageName) && !alreadyDownloadedPackages.Contains(packageName)) | ||
| { | ||
| notYetDownloadedPackages.Add(packageName); | ||
| } | ||
| } | ||
|
|
||
| // Determine if ASP.NET is used. | ||
| if (!useAspNetDlls) | ||
| { | ||
| useAspNetDlls = | ||
| IsGroupMatch(line, ProjectSdk(), "Sdk", "Microsoft.NET.Sdk.Web") || | ||
| IsGroupMatch(line, FrameworkReference(), "Include", "Microsoft.AspNetCore.App"); | ||
| } | ||
| } | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| progressMonitor.FailedToReadFile(file, ex); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| [GeneratedRegex("<PackageReference.*\\sInclude=\"(.*?)\".*/?>", RegexOptions.IgnoreCase | RegexOptions.Compiled | RegexOptions.Singleline)] | ||
| private static partial Regex PackageReference(); | ||
|
|
||
| [GeneratedRegex("<FrameworkReference.*\\sInclude=\"(.*?)\".*/?>", RegexOptions.IgnoreCase | RegexOptions.Compiled | RegexOptions.Singleline)] | ||
| private static partial Regex FrameworkReference(); | ||
|
|
||
| [GeneratedRegex("<(.*\\s)?Project.*\\sSdk=\"(.*?)\".*/?>", RegexOptions.IgnoreCase | RegexOptions.Compiled | RegexOptions.Singleline)] | ||
| private static partial Regex ProjectSdk(); | ||
| } | ||
| } | ||
|
|
||
| internal interface IUnsafeFileReader | ||
| { | ||
| IEnumerable<string> ReadLines(string file); | ||
| } | ||
|
|
||
| internal class UnsafeFileReader : IUnsafeFileReader | ||
| { | ||
| public IEnumerable<string> ReadLines(string file) | ||
| { | ||
| using var sr = new StreamReader(file); | ||
| string? line; | ||
| while ((line = sr.ReadLine()) != null) | ||
| { | ||
| yield return line; | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.