JS: removed unnecessary findlast module import

github · Nov 19, 2024 · 1b0f8aa · 1b0f8aa
1 parent 72a69cf
commit 1b0f8aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/javascript/ql/lib/change-notes/2024-11-18-ES2022-find-functions.md b/javascript/ql/lib/change-notes/2024-11-18-ES2022-find-functions.md
@@ -1,4 +1,5 @@
 ---
 category: minorAnalysis
 ---
-* Added pre call graph step for `Array.prototype.findLast`  
+* Added taint-steps for `Array.prototype.findLast`  
+* Added taint-steps for `Array.prototype.findLastIndex`
diff --git a/javascript/ql/lib/semmle/javascript/Arrays.qll b/javascript/ql/lib/semmle/javascript/Arrays.qll
@@ -390,10 +390,7 @@ private module ArrayLibraries {
     result.(DataFlow::MethodCallNode).getMethodName() in ["find", "findLast"] and
     array = result.getReceiver()
     or
-    result =
-      DataFlow::moduleImport([
-          "array.prototype.find", "array-find", "array.prototype.findLast", "array-find-last"
-        ]).getACall() and
+    result = DataFlow::moduleImport(["array.prototype.find", "array-find"]).getACall() and
     array = result.getArgument(0)
   }