Remove field only used in characteristic predicate

github · Aug 16, 2023 · 24eb98b · 24eb98b
1 parent 42036ac
commit 24eb98b
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/java/ql/lib/semmle/code/java/security/RandomDataSource.qll b/java/ql/lib/semmle/code/java/security/RandomDataSource.qll
@@ -157,12 +157,11 @@ class ApacheCommonsRandomSource extends RandomDataSource {
  * A method access calling a method declared on `org.apache.commons.lang3.RandomStringUtils`
  */
 class ApacheCommonsRandomStringSource extends RandomDataSource {
-  Method m;
-
   ApacheCommonsRandomStringSource() {
-    m = this.getMethod() and
-    m.getName().matches("random%") and
-    m.getDeclaringType().hasQualifiedName("org.apache.commons.lang3", "RandomStringUtils")
+    exists(Method m | m = this.getMethod() |
+      m.getName().matches("random%") and
+      m.getDeclaringType().hasQualifiedName("org.apache.commons.lang3", "RandomStringUtils")
+    )
   }
 
   override Expr getOutput() { result = this }