Adjust exit code for binlog extraction

github · Jun 6, 2024 · 38660a0 · 38660a0
1 parent d229009
commit 38660a0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs b/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs
@@ -120,7 +120,7 @@ public static ExitCode Run(string[] args)
                 };
 
                 var compilerCalls = BinaryLogUtil.ReadAllCompilerCalls(fileStream, predicate);
-                var exitCode = ExitCode.Ok;
+                var allFailed = true;
                 foreach (var compilerCall in compilerCalls)
                 {
                     var diagnosticName = compilerCall.GetDiagnosticName();
@@ -130,13 +130,13 @@ public static ExitCode Run(string[] args)
                     compilerCallOptions.CompilerArguments.AddRange(compilerCall.GetArguments());
                     logger.LogInfo($"Running extractor on arguments from binary log. Processing {diagnosticName}.");
                     var ec = Run(compilerCallOptions, logger);
-                    if (ec != ExitCode.Ok)
+                    if (ec != ExitCode.Failed)
                     {
-                        exitCode = ec;
+                        allFailed &= false;
                     }
                 }
 
-                return exitCode;
+                return allFailed ? ExitCode.Failed : ExitCode.Ok;
             }
             else
             {