-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #13880 from MathiasVP/type-bounds-preparation
C++: Add a type-based `SemReason`.
- Loading branch information
Showing
5 changed files
with
195 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/Reason.qll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /** | ||
| * Provides a `Make` parameterized module for constructing a `Reason` type that is used | ||
| * when implementing the `LangSig` module. | ||
| */ | ||
|
|
||
| private import semmle.code.cpp.rangeanalysis.new.internal.semantic.Semantic | ||
|
|
||
| /** The necessary parameters that must be implemented to instantiate `Make`. */ | ||
| signature module ParamSig { | ||
| class TypeReasonImpl; | ||
| } | ||
|
|
||
| /** | ||
| * The module that constructs a `Reason` type when provided with an implementation | ||
| * of `ParamSig`. | ||
| */ | ||
| module Make<ParamSig Param> { | ||
| private import Param | ||
|
|
||
| private newtype TSemReason = | ||
| TSemNoReason() or | ||
| TSemCondReason(SemGuard guard) or | ||
| TSemTypeReason(TypeReasonImpl trc) | ||
|
|
||
| /** | ||
| * A reason for an inferred bound. This can either be `CondReason` if the bound | ||
| * is due to a specific condition, or `NoReason` if the bound is inferred | ||
| * without going through a bounding condition. | ||
| */ | ||
| abstract class SemReason extends TSemReason { | ||
| /** Gets a textual representation of this reason. */ | ||
| abstract string toString(); | ||
|
|
||
| bindingset[this, reason] | ||
| abstract SemReason combineWith(SemReason reason); | ||
| } | ||
|
|
||
| /** | ||
| * A reason for an inferred bound that indicates that the bound is inferred | ||
| * without going through a bounding condition. | ||
| */ | ||
| class SemNoReason extends SemReason, TSemNoReason { | ||
| override string toString() { result = "NoReason" } | ||
|
|
||
| override SemReason combineWith(SemReason reason) { result = reason } | ||
| } | ||
|
|
||
| /** A reason for an inferred bound pointing to a condition. */ | ||
| class SemCondReason extends SemReason, TSemCondReason { | ||
| /** Gets the condition that is the reason for the bound. */ | ||
| SemGuard getCond() { this = TSemCondReason(result) } | ||
|
|
||
| override string toString() { result = this.getCond().toString() } | ||
|
|
||
| bindingset[this, reason] | ||
| override SemReason combineWith(SemReason reason) { | ||
| // Since we end up reporting a `SemReason` for the inferred bound we often pick somewhat | ||
| // arbitrarily between two `SemReason`s during the analysis. This isn't an issue for most reasons | ||
| // since they're mainly used for constructing alert messages. However, the `SemTypeReason` is | ||
| // supposed to be used in query logic to filter out bounds inferred by type-based analysis if | ||
| // the query author chooses to do so. So we need to ensure that if _any_ of the bounds that | ||
| // contribute to the final bound depends on type information then the `SemReason` we report must | ||
| // be a `SemTypeReason`. So when we need to combine this `SemCondReason` with a `SemTypeReason` | ||
| // the result should always be a `SemTypeReason`. | ||
| if reason instanceof SemTypeReason then result instanceof SemTypeReason else result = this | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * A reason for an inferred bound that indicates that the bound is inferred | ||
| * based on type-information. | ||
| */ | ||
| class SemTypeReason extends SemReason, TSemTypeReason { | ||
| TypeReasonImpl impl; | ||
|
|
||
| SemTypeReason() { this = TSemTypeReason(impl) } | ||
|
|
||
| override string toString() { result = "TypeReason" } | ||
|
|
||
| bindingset[this, reason] | ||
| override SemReason combineWith(SemReason reason) { result = this and exists(reason) } | ||
| } | ||
| } |