Merge pull request #13942 from hvitved/dataflow/variable-capture-cons…

…istency-fix
github · Aug 10, 2023 · 5a6ce29 · 5a6ce29
2 parents f6aca58 + 9b38028
commit 5a6ce29
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/shared/dataflow/codeql/dataflow/VariableCapture.qll b/shared/dataflow/codeql/dataflow/VariableCapture.qll
@@ -371,9 +371,10 @@ module Flow<InputSig Input> implements OutputSig<Input> {
     query predicate uniqueWriteCfgNode(string msg) { uniqueWriteCfgNode(_, msg) }
 
     private predicate localWriteStep(VariableWrite vw, string msg) {
-      exists(BasicBlock bb |
-        vw.hasCfgNode(bb, _) and
-        bb.getEnclosingCallable() != vw.getVariable().getCallable() and
+      exists(BasicBlock bb1, BasicBlock bb2 |
+        vw.hasCfgNode(bb1, _) and
+        vw.getSource().hasCfgNode(bb2, _) and
+        bb1.getEnclosingCallable() != bb2.getEnclosingCallable() and
         msg = "VariableWrite is not a local step"
       )
     }