Convert shared CFG construction library to a parameterized module #13509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
cfg-pack
branch
3 times, most recently
from
baa7bb3
to
6c3cf4e
Compare
hvitved
force-pushed
the
cfg-pack
branch
3 times, most recently
from
5067515
to
37d9875
Compare
aibaars
reviewed
Jul 10, 2023
| * For more information about locations see [Locations](https://codeql.github.com/docs/writing-codeql-queries/providing-locations-in-codeql-queries/). | ||
| */ | ||
| signature class LocationSig { | ||
| /** Gets the 1-based line number (inclusive) where this location starts. */ |
There was a problem hiding this comment.
I guess you "forgot" getFile on purpose, right?
There was a problem hiding this comment.
Yes, because that would require a File class in scope.
MathiasVP
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the existing
ControlFlowGraphImplShared.qllto a parameterized module, and puts it into a newcontrolflowQL pack (where, eventually, we can also put stuff like basic blocks and guards). In this PR, only Ruby is adopting the new shared library; I plan to do C# follow-up, and perhaps Swift (unless @github/codeql-swift beats me to it).Whitespace-insensitive commit-by-commit review is suggested.
The PR makes use of2.14.0 has now been released, so this PR is safe to merge.extendsinside parameterized modules, which is only publicly supported in 2.14.0 (expected to be released July 11th), so cannot be merged until then (this is the reason why the CI checkCompile all queries using the latest stable CodeQL CLIcurrently fails).