Create separate automodel pack #13879
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||
| #!/bin/sh | ||||||
| set -e | ||||||
|
|
||||||
| AUTOMODEL_ROOT="$(dirname $0)" | ||||||
| WORKSPACE_ROOT="$AUTOMODEL_ROOT/../../../.." | ||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. I have always been using There was a problem hiding this comment. I'm not sure. I've usually just used |
||||||
| GRPS="automodel,-test" | ||||||
|
|
||||||
| if [ -z "$CODEQL_DIST" ]; then | ||||||
|
There was a problem hiding this comment. (Optional)...you could also check if There was a problem hiding this comment. Lets defer that in case we want to make changes to the solorigate pack as well. |
||||||
| echo "CODEQL_DIST not set" | ||||||
| exit -1 | ||||||
| fi | ||||||
|
|
||||||
| cd "$AUTOMODEL_ROOT" | ||||||
| echo Testing automodel queries | ||||||
| "${CODEQL_DIST}/codeql" test run test | ||||||
|
|
||||||
| cd "$WORKSPACE_ROOT" | ||||||
|
|
||||||
| echo Preparing release | ||||||
| "${CODEQL_DIST}/codeql" pack release --groups $GRPS | ||||||
|
|
||||||
| echo Publishing automodel | ||||||
| "${CODEQL_DIST}/codeql" pack publish --groups $GRPS | ||||||
|
|
||||||
| echo Bumping versions | ||||||
| "${CODEQL_DIST}/codeql" pack post-release --groups $GRPS | ||||||
|
|
||||||
| echo Automodel packs successfully published. Please commit and push the version changes. | ||||||
|
There was a problem hiding this comment. If you wanted to be extra fancy, you could commit and push directly from this script. There was a problem hiding this comment. Hmm... I kind of like it not committing for me, then there is less that suddenly happens. But we can also tweak this afterwards. It almost seems like there should be a generic publish script we could have for all the separate packs, but I am not sure how frequent these separate packs are? There was a problem hiding this comment. If this script is going to be run in CI, then something will have to commit and push the change, but maybe that is a longer term goal. Eventually, all of our core packs will be publishable separately. But, that won't happen for a while. I still would hope that something like this script would become the default way of publishing. |
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| name: codeql/java-automodel-queries | ||
| version: 0.0.1-dev | ||
| groups: | ||
| - java | ||
| - automodel | ||
| dependencies: | ||
| codeql/java-all: ${workspace} | ||
| warnOnImplicitThis: true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: codeql/java-automodel-tests | ||
| version: 0.0.1-dev | ||
| groups: | ||
| - java | ||
| - automodel | ||
| - test | ||
| dependencies: | ||
| codeql/java-all: ${workspace} | ||
| codeql/java-automodel-queries: ${workspace} | ||
| extractor: java | ||
| tests: . | ||
| warnOnImplicitThis: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that the original script has this same line (which I wrote a couple of years ago), but not sure if it's the best. This script is only running successfully from the
codeql/java/ql/automodeldirectory. Running in the repo root is failing for some reason.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah...I think the path in line 5 needs to be normalized. Running from the repo root will make
WORKSPACE_ROOT=java/ql/automodel/../../.., but it really needs to beWORKSPACE_ROOT=..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed this to do:
Happy to switch to
realpathas well if that is better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also updated the solorigate script with this change.