Java: automodel application mode: use endpoint class like in framework mode

[kaeluka]

There now is a new endpoint class in application mode that mirrors the one we recently added to framework mode. The new class additionally has proper support for vararg arrays.

You'll find some documentation of how the class behaves in the qll file.
The test case in Test.java shows how varargs are treated.

Questions for Reviewers

• For varargs arguments, we only use the first argument passed as endpoint (example). This is easy and avoids redundancy. We're not forced to do it that way, but it makes sense to me. Otherwise, we'd push complexity to the the classification script (eg., it might decide to use competing classifications for a given MaD model) and to the triage tooling. Do you agree?

fyi, @jhelie

[kaeluka]

@jcogs33, are you able to take a look? CI Checks are ✅

[jcogs33]

@jcogs33, are you able to take a look? CI Checks are ✅

Sure, I'll try to take a look sometime tomorrow (2023/08/09).

[jcogs33]

I added a couple minor questions, otherwise looks reasonable to me. You might want a second pair of 👀 since I'm not sure if I'm familiar enough with the automodel code (as my questions might show 🙂).

For varargs arguments, we only use the first argument passed as endpoint (example). This is easy and avoids redundancy. We're not forced to do it that way, but it makes sense to me. Otherwise, we'd push complexity to the the classification script (eg., it might decide to use competing classifications for a given MaD model) and to the triage tooling. Do you agree?

I agree that just using the the first varargs argument as endpoint sounds like the best solution.

[kaeluka]

Thanks for the thorough review 🥳 I think I've addressed your comments :)

[jcogs33]

Looks reasonable to me :)