Ruby: Use the new dataflow API for checked in queries #14124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrford
force-pushed
the
rb/dataflow-query-refactor
branch
from
7051b65
to
9885173
Compare
|
Worth noting - this increases cache sizes significantly. This seems to be expected and has also occurred in other languages that have made this change. |
hvitved
requested changes
Sep 6, 2023
ruby/ql/lib/codeql/ruby/experimental/UnicodeBypassValidationQuery.qll
Outdated
Show resolved
Hide resolved
ruby/ql/lib/codeql/ruby/security/HardcodedDataInterpretedAsCodeQuery.qll
Outdated
Show resolved
Hide resolved
ruby/ql/lib/codeql/ruby/security/HardcodedDataInterpretedAsCodeQuery.qll
Outdated
Show resolved
Hide resolved
ruby/ql/src/queries/security/cwe-506/HardcodedDataInterpretedAsCode.ql
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@hvitved thanks for the review - updated this branch. |
hvitved
previously approved these changes
Sep 13, 2023
hvitved
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
DataFlow::ConfigSigmodule signature instead of theDataFlow::Configurationclass.The general naming convention is
SomeQueryFlowfor the flow module for theSomeQuery.qlquery.In most cases the old configuration has been left in place and deprecated. For cases where the configuration was defined in the query file itself (i.e. within
src), I've just deleted the old configuration as it's not part of a CodeQL library.Any barrier guard predicates have been dropped. I don't think we have any cases where this makes a difference, unless the barrier guard abstract classes are extended externally (i.e. not within this repo).
There are some very tiny changes to flow steps in some places, reflected in updated
.expectedoutput. These seem to be benign or minor improvements as far as I can tell.Two queries,
rb/http-to-file-accessandrb/tainted-format-stringshare a*Query.qllfile with JS. I've reverted the changes to these queries for now - I think it'll be slightly cleaner to do the Ruby and JS changes for these in a separate PR.