Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Automodel, new candidates fix #14184

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Java: Automodel, new candidates fix #14184

merged 5 commits into from
Sep 13, 2023

Conversation

kaeluka
Copy link
Contributor

@kaeluka kaeluka commented Sep 12, 2023 •
edited
Loading

Following some discussions (backref), this updates a few details of the newly extracted automodel candidates and examples.

  • adds extensibleType to metadata
  • extracts method doc and class doc as in framework mode. However, these will often not be available, as in application mode, the method we build a model will generally live in a different code base. I suggest coming back to this topic once we craft prompts.

@github-actions github-actions bot added the Java label Sep 12, 2023
@kaeluka kaeluka requested a review from tausbn September 12, 2023 12:26
@kaeluka kaeluka added the no-change-note-required This PR does not need a change note label Sep 12, 2023
@kaeluka kaeluka marked this pull request as ready for review September 12, 2023 12:27
@kaeluka kaeluka requested a review from a team as a code owner September 12, 2023 12:27
tausbn
tausbn previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment (which I am fine with leaving as future work), otherwise I think this looks good (and hence give my approval now). 👍

...l/test/AutomodelApplicationModeExtraction/AutomodelApplicationModeExtractCandidates.expected Outdated Show resolved Hide resolved
tausbn
tausbn approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@kaeluka kaeluka merged commit 7a7dc9b into main Sep 13, 2023
6 checks passed
@kaeluka kaeluka deleted the kaeluka/application-mode-new-candidates-fixes branch September 13, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn approved these changes

Assignees
No one assigned
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaeluka @tausbn