Swift: Add sinks for sqlite3 and SQLite.swift to swift/cleartext-storage-database #14312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext-storage-database.
rdmarsh2
reviewed
Sep 28, 2023
| ";QueryType;true;insert(_:);;;Argument[0];database-store", | ||
| ";QueryType;true;insert(_:_:);;;Argument[0..1];database-store", | ||
| ";QueryType;true;insert(or:_:);;;Argument[1];database-store", | ||
| ";QueryType;true;insertMany(_:);;;Argument[0];database-store", |
There was a problem hiding this comment.
Should this be Argument[0].CollectionElement?
There was a problem hiding this comment.
Yes, but it can't be because at present MAD doesn't support access path syntax on sinks (or sources). I'm pushing for this feature because I think it's the natural way to express sinks like this.
The case should covered by the additional taint step at present, and that will be upgraded to an implicit read step in this query in #14357 .
I've just added tests for insertMany to this PR, as it's a special case that clearly deserves a test of its own.
|
Fixed merge conflicts. |
geoffw0
force-pushed
the
sqlpathinject2
branch
from
bfe4357
to
fdcc6b4
Compare
rdmarsh2
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sinks for the sqlite3 C API and SQLite.swift library to the
swift/cleartext-storage-databasequery - i.e. places where these libraries write data to a database. Also adds a small number of flow summaries for SQLite.Swift, which has an interface where you construct objects representing interfaces (only a small part of this is modelled, we will only catch very simple uses of that particular interface for now).Performance seems unaffected (DCA will confirm).
MRVA run found no new results from these changes (though quite a lot of new results since public beta).