Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go tools version from v0.11.1 to v0.13.0 #14314

Merged
merged 2 commits into from
Sep 26, 2023
Merged

update go tools version from v0.11.1 to v0.13.0 #14314

merged 2 commits into from
Sep 26, 2023

Conversation

taigrr
Copy link
Contributor

@taigrr taigrr commented Sep 26, 2023

Some of the tooling on the module imports isn't working as expected in my automated CI, i.e. x.y.z go mod versions don't seem to be supported, only x.y (the new support for 1.21.1 is triggering this for me).

This project is laid out a bit differently with the vendoring than most projects I've used, so someone should double-check my work, but I think I updated the tools package correctly.

@taigrr taigrr requested a review from a team as a code owner September 26, 2023 01:40
@github-actions github-actions bot added the Go label Sep 26, 2023
@taigrr taigrr mentioned this pull request Sep 26, 2023
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for opening this PR! ✨ The changes look reasonable to me and I am happy for us to bump the version of these dependencies to the latest version, even though it is not required to fix the problem you ran into, as discussed in that issue.

@mbg mbg merged commit 539199b into github:main Sep 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants