Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External flow: standardize empty.model.yml #16392

Merged

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented May 1, 2024

No description provided.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label May 1, 2024
@owen-mc owen-mc requested review from a team as code owners May 1, 2024 21:03
michaelnebel
michaelnebel previously approved these changes May 2, 2024
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,4 +1,6 @@
extensions:
# Make sure that the extensible model predicates have at least one definition
# to avoid errors about an undefined extensionals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 'an'?

Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java LGTM + what @hvitved said.

@asgerf
Copy link
Contributor

asgerf commented May 2, 2024

LGTM assuming the fix from @hvitved is in

Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 👍

@owen-mc owen-mc merged commit 9bfb189 into github:main May 2, 2024
41 of 42 checks passed
@owen-mc owen-mc deleted the external-flow/standardize-empty-model-yml branch May 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants