Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared data flow: Make summaryThroughStepValue include param outputs #16444

Merged

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented May 7, 2024

This matches summaryThroughStepTaint.

This matches summaryThroughStepTaint.
hvitved
hvitved previously approved these changes May 7, 2024
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure to run DCA for all (relevant) languages.

@owen-mc owen-mc marked this pull request as ready for review May 7, 2024 20:36
@owen-mc owen-mc requested a review from a team as a code owner May 7, 2024 20:36
@owen-mc
Copy link
Contributor Author

owen-mc commented May 7, 2024

DCA runs all seem fine to me.

@hvitved hvitved added the no-change-note-required This PR does not need a change note label May 8, 2024
@owen-mc owen-mc merged commit 0338ffd into github:main May 8, 2024
32 of 33 checks passed
@owen-mc owen-mc deleted the shared/update-summary-through-step-value branch May 8, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants