C++: Make IRGuardCondition handle p in if(p) and if(!p) better in C programs
#16533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
force-pushed
the
better-negation-guards-in-c
branch
2 times, most recently
from
ed615a3
to
40bcef7
Compare
MathiasVP
force-pushed
the
better-negation-guards-in-c
branch
from
40bcef7
to
5893e38
Compare
|
Indeed, this has been confirmed on Slack now |
geoffw0
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves our
GuardConditionsupport for reasoning aboutpin the following example:This was actually the thing I excluded in #16364 and #16364 (comment) explains why this is non-trivial. This PR does the non-trivial work required to infer the right (in)equalities.