Go: Add environment variable to include vendor directories in extraction
#16925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If set to `true`, this allows `vendor` directories to be extracted
owen-mc
approved these changes
Jul 8, 2024
|
@owen-mc I have merged this for now as is, but putting the new logic into a separate function is something we can definitely do when we next touch this part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new environment variable
CODEQL_EXTRACTOR_GO_EXTRACT_VENDOR_DIRSwhich, if set totrue, includesvendordirectories in the extraction. I have also added an integration test to verify that avendordirectory is included in the extraction with this environment variable set to true. Specifically,test.expecteddoes not containsrc/vendor/example.com/test/add.goifCODEQL_EXTRACTOR_GO_EXTRACT_VENDOR_DIRSis nottrueor with an old version of the extractor.