Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Accept test changes caused by new CLI version. #17161

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Aug 6, 2024

Similar to #17139 but for C++.

@geoffw0 geoffw0 added C++ no-change-note-required This PR does not need a change note labels Aug 6, 2024
@geoffw0 geoffw0 requested a review from a team as a code owner August 6, 2024 15:47
@alexet
Copy link
Contributor

alexet commented Aug 6, 2024

Can you target the release branch as a hotfix please.

@geoffw0
Copy link
Contributor Author

geoffw0 commented Aug 6, 2024

Is that codeql-cli-2.18.2??? Should I open a second PR or attempt to re-target this one?

@dbartol dbartol merged commit b2d20f1 into github:main Aug 6, 2024
11 checks passed
@dbartol
Copy link
Contributor

dbartol commented Aug 6, 2024

I've merged this one into main but I'm creating a hotfix PR right now.

@dbartol
Copy link
Contributor

dbartol commented Aug 6, 2024

Hotfix PR: #17163

@geoffw0
Copy link
Contributor Author

geoffw0 commented Aug 6, 2024

Thanks @dbartol

@geoffw0 geoffw0 deleted the madfix branch October 29, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants