Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go / configure-baseline: account for multiple vendor directories and the CODEQL_EXTRACTOR_GO_EXTRACT_VENDOR_DIRS setting #17227

Merged
merged 13 commits into from
Aug 22, 2024
Merged

Go / configure-baseline: account for multiple vendor directories and the CODEQL_EXTRACTOR_GO_EXTRACT_VENDOR_DIRS setting #17227

merged 13 commits into from
Aug 22, 2024

Commits on Aug 20, 2024

  1. Go / configure-baseline: account for multiple vendor directories and … 

    …the `CODEQL_EXTRACTOR_GO_EXTRACT_VENDOR_DIRS` setting

Our existing configure-baseline scripts would give the wrong result if a `vendor` directory wasn't at the root of the repository, or if the `CODEQL_EXTRACTOR_GO_EXTRACT_VENDOR_DIRS` variable was set to `true` indicating the user wants their vendored code scanned.

Here I replace the shell scripts that implemented the very simplest behaviour with a small Go program.
    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    21366dd View commit details
    Browse the repository at this point in the history

  2. Tidy comments

    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    624d2b8 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary batch script flag

    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5d34dbf View commit details
    Browse the repository at this point in the history

  4. Improve struct naming

    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    22802fd View commit details
    Browse the repository at this point in the history

  5. Share vendor-dir extraction logic between extractor and configure-bas… 

    …eline script
    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f1f6f9b View commit details
    Browse the repository at this point in the history

  6. Clarify comment

    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ea3e5c8 View commit details
    Browse the repository at this point in the history

  7. Update bazel build files

    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8b9617c View commit details
    Browse the repository at this point in the history

  8. Output to stdout, not stderr

    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    15b5bcc View commit details
    Browse the repository at this point in the history

  9. Add configure-baseline integration test

    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3acab64 View commit details
    Browse the repository at this point in the history

  10. Change note

    @smowton
    smowton committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    fc30120 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Switch test expectations to use unix-style paths

    @smowton
    smowton committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c99a846 View commit details
    Browse the repository at this point in the history

  2. Use platform path separators for file testing, and forward-slashes fo… 

    …r reporting to CodeQL
    @smowton
    smowton committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2939cef View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @smowton
    smowton committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f13f19d View commit details
    Browse the repository at this point in the history